Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add filtering details to EXPLAIN and PROFILE #1265

Merged
merged 20 commits into from Oct 25, 2023
Merged

Add filtering details to EXPLAIN and PROFILE #1265

merged 20 commits into from Oct 25, 2023

Conversation

antepusic
Copy link
Contributor

@antepusic antepusic commented Sep 18, 2023 •
edited

This PR extends the EXPLAIN and PROFILE clauses with detailed information about the Filter operator.

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

Add detailed Filter operator info to EXPLAIN and PROFILE clauses

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses

We’ve improved query inspection using EXPLAIN and PROFILE clauses by adding information about the operands of the Filter operator.

  • Tag someone from docs team in the comments

@antepusic antepusic self-assigned this Sep 18, 2023
@antepusic antepusic added feature feature Ready for review PR is ready for review Docs needed Docs needed and removed draft labels Sep 18, 2023
@antepusic antepusic marked this pull request as ready for review September 18, 2023 20:52
as51340
as51340 requested changes Sep 19, 2023
View reviewed changes
src/query/plan/pretty_print.cpp Outdated Show resolved Hide resolved
src/query/plan/preprocess.hpp Outdated Show resolved Hide resolved
src/query/plan/preprocess.hpp Show resolved Hide resolved
src/query/plan/operator.hpp Outdated Show resolved Hide resolved
src/query/plan/operator.cpp Show resolved Hide resolved
src/query/plan/operator.hpp Show resolved Hide resolved
@as51340
Copy link
Contributor

as51340 commented Sep 19, 2023

Good job Ante, I have few ideas how to improve it and good to go

as51340
as51340 approved these changes Sep 19, 2023
View reviewed changes
Copy link
Contributor

@as51340 as51340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adopt the change in this comment or don't it is up to you, LGTM

src/query/plan/operator.cpp Show resolved Hide resolved
@gitbuda gitbuda added this to the mg-v2.12.0 milestone Sep 19, 2023
antoniofilipovic
antoniofilipovic requested changes Sep 20, 2023
View reviewed changes
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment, good job!

src/query/plan/preprocess.hpp Outdated Show resolved Hide resolved
@antoniofilipovic antoniofilipovic added Needs change PR needs change and removed Ready for review PR is ready for review labels Sep 20, 2023
@gitbuda gitbuda changed the title [master < T1265] Add filtering details to EXPLAIN and PROFILE Add filtering details to EXPLAIN and PROFILE Sep 24, 2023
@antepusic antepusic added Ready for review PR is ready for review and removed Needs change PR needs change labels Oct 23, 2023
@antepusic antepusic mentioned this pull request Oct 23, 2023
Merged
9 tasks
@antepusic
Copy link
Contributor Author

@vpavicic Release note in the original comment

@antoniofilipovic antoniofilipovic merged commit 3158a16 into master Oct 25, 2023
6 checks passed
@antoniofilipovic antoniofilipovic deleted the filter-info branch October 25, 2023 19:36
antepusic added a commit that referenced this pull request Oct 25, 2023
@antepusic
Fix test to align with #1265 being merged
788e7f9
as51340 pushed a commit that referenced this pull request Nov 10, 2023
@antepusic @as51340
Add filtering details to EXPLAIN and PROFILE (#1265)
e43f950
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@as51340 as51340 as51340 approved these changes

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

Assignees

@antepusic antepusic

Labels
Docs needed Docs needed feature feature Ready for review PR is ready for review
Projects
No open projects
memgraph-v2 issues
Status: 👀 In review
Milestone
mg-v2.12.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@antepusic @as51340 @antoniofilipovic @gitbuda