-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master < T1266] Improve deserialization performance #1266
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as51340
changed the title
[master < ] Improve deserialization performance
[master < T1266] Improve deserialization performance
Sep 18, 2023
Darych
reviewed
Sep 18, 2023
Darych
reviewed
Sep 20, 2023
Darych
approved these changes
Sep 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
as51340
added
Docs unnecessary
Docs unnecessary
Docs - changelog only
Docs - changelog only
labels
Sep 21, 2023
Release note: The reading performance of vertices has been improved 2x for disk storage. |
Reading of nodes stored on disk is now 2x faster. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preparation query:
Before optimization:
Ran 5 times, avg. is: 0.5718
After:
Ran 5 times, avg. is: 0.3094
Conclusion: Roughly this PR gives 2x faster data deserialization from disk. Loading all edges isn't improved because the cost comes from different place.
[master < Epic] PR
[master < Task] PR
To keep docs changelog up to date, one more thing to do: