New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve expansions on disk #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignition
approved these changes
Oct 10, 2023
Darych
reviewed
Oct 10, 2023
10 tasks
10 tasks
Darych
reviewed
Oct 11, 2023
10 tasks
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs:
memgraph/documentation#252
NOTE:
Some e2e disk tests are disabled since a lot of things changes in this PR. All commented tests aren't that important for our workloads (query modules interacting with writing to DB, mock API, triggers...). This PR makes it possible to run 1-hop expansions with 30 Q/s. Currently, the performance of 1-hop expansion is 0.5 Q/s. Next PRs will deal with further improvements.
Tasks:
Currently, serializing edges across multiple column families should be solved. That means creating edges and modifying edges should work.
Create out_edges and in_edges column families ✅
Serializing edges ✅
Remove prefetching edges ✅
Modify edge creation ✅
Modify edge deletion ✅
Delete vertex ✅
Detach delete vertex ✅
Refactored indices ✅
Made thinner vertex and edge accessors by sending pointer to the storage. ✅
How to call OutEdges? ✅
How to call InEdges? ✅
fix all unit tests ✅
revert changes from some unit tests now that we handle changes from the current transaction ✅
[master < Epic] PR
[master < Task] PR
To keep docs changelog up to date, one more thing to do: