New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add constraint verification update only on necessary actions #1341
Merged
Josipmrden
merged 26 commits into
master
from
constraint-verification-update-only-on-necessary-actions
Oct 25, 2023
Merged
Add constraint verification update only on necessary actions #1341
Josipmrden
merged 26 commits into
master
from
constraint-verification-update-only-on-necessary-actions
Oct 25, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrejtonev
reviewed
Oct 19, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Some comments (in part just from me being confused :))
andrejtonev
approved these changes
Oct 24, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
…s' of github.com:memgraph/memgraph into constraint-verification-update-only-on-necessary-actions
Josipmrden
deleted the
constraint-verification-update-only-on-necessary-actions
branch
October 25, 2023 14:01
as51340
pushed a commit
that referenced
this pull request
Nov 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Constraints are always verified in memgraph, even if edges are being added into the database only as a modification. Therefore, appropriate flag is being set in the transaction if constraints really need to be modified.
[master < Task] PR
To keep docs changelog up to date, one more thing to do:
@vpavicic : Optimized verification of unique and existence constraints. Constraints are now not verified on nodes if exactly the properties that are triggering change in unique constraint indexes are updated.