Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide textual information for inefficient plans with notifications #1343

Merged
merged 14 commits into from Oct 24, 2023

Conversation

Josipmrden
Copy link
Contributor

@Josipmrden Josipmrden commented Oct 10, 2023

Users are often not creating indices when using read queries. Therefore, textual information is added via notifications to provide users with info and remind them to create indices.

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses
  • Tag someone from docs team in the comments

@vpavicic : Provided textual hints in Memgraph notification system which will be available to read in mgconsole and Memgraph Lab

closes #1321

@Josipmrden Josipmrden self-assigned this Oct 10, 2023
@Josipmrden Josipmrden added the feature feature label Oct 10, 2023
@Josipmrden Josipmrden added this to the mg-v2.12.0 milestone Oct 10, 2023
src/query/plan/hint_provider.hpp Outdated Show resolved Hide resolved
src/query/plan/hint_provider.hpp Show resolved Hide resolved
src/query/plan/hint_provider.hpp Show resolved Hide resolved
@Josipmrden Josipmrden linked an issue Oct 18, 2023 that may be closed by this pull request
@Josipmrden Josipmrden marked this pull request as ready for review October 18, 2023 12:52
src/query/plan/hint_provider.hpp Outdated Show resolved Hide resolved
src/query/plan/hint_provider.hpp Show resolved Hide resolved
src/query/plan/preprocess.hpp Outdated Show resolved Hide resolved
src/query/plan/hint_provider.hpp Show resolved Hide resolved
src/query/plan/hint_provider.hpp Outdated Show resolved Hide resolved
src/query/plan/hint_provider.hpp Outdated Show resolved Hide resolved
src/query/plan/hint_provider.hpp Outdated Show resolved Hide resolved
src/query/plan/hint_provider.hpp Outdated Show resolved Hide resolved
src/query/plan/hint_provider.hpp Outdated Show resolved Hide resolved
@Josipmrden Josipmrden added the Docs - changelog only Docs - changelog only label Oct 24, 2023
src/query/plan/hint_provider.hpp Show resolved Hide resolved
@Josipmrden Josipmrden merged commit e617ff9 into master Oct 24, 2023
6 checks passed
@Josipmrden Josipmrden deleted the textual-information-for-inefficient-plans branch October 24, 2023 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs - changelog only Docs - changelog only feature feature
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

Enable textual context on query runs about plan inefficiencies Enable indexing hints during query runs
4 participants