Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash caused by deleting non-existing relationship in DETACH DELETE clause #1355

Merged
merged 5 commits into from Oct 23, 2023

Conversation

DavIvek
Copy link
Contributor

@DavIvek DavIvek commented Oct 12, 2023

This PR is about preventing a crash caused by deleting a non-existing relationship.

ATM query:
CREATE (n0)<-[r0:T3]-(n1) DETACH DELETE n0 DETACH DELETE r0 RETURN n1;
will crash the database.

The problem is in the second DETACH DELETE clause in which we are trying to detach relationship r0 from its edges, since edge n0 is deleted by the previous DETACH DELETE clause, that will crash a database.

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses
  • Tag someone from docs team in the comments

closes #1329

@DavIvek DavIvek added the bug bug label Oct 12, 2023
@DavIvek DavIvek self-assigned this Oct 12, 2023
@DavIvek DavIvek marked this pull request as draft October 12, 2023 13:33
@DavIvek DavIvek marked this pull request as ready for review October 13, 2023 07:53
@gitbuda gitbuda merged commit 3ff2c72 into master Oct 23, 2023
5 of 6 checks passed
@gitbuda gitbuda deleted the fix-crash-on-detach-delete branch October 23, 2023 06:36
@gitbuda gitbuda added this to the mg-v2.12.0 milestone Oct 23, 2023
@DavIvek DavIvek added the Docs unnecessary Docs unnecessary label Nov 2, 2023
@vpavicic vpavicic added Docs - changelog only Docs - changelog only and removed Docs unnecessary Docs unnecessary labels Nov 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bug Docs - changelog only Docs - changelog only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Crash caused by deleting non-existing relationship
5 participants