-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add renaming of edge types #1364
Conversation
@antoniofilipovic & @imilinovic, if I recall correctly, by definition, edge types are immutable in the property graph -> take a look for incompatibilities and edge cases on that side (maybe some application code relies on that fact) 🤔 |
@gitbuda Basically this PR is used only for APOC functionality of renaming edge type: https://neo4j.com/labs/apoc/4.3/overview/apoc.refactor/apoc.refactor.rename.type/. Neo4j supports it so we wanted to add support on MAGE. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, but good work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, but good work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me
@vpavicic Will do docs today |
There was a need to be able to change edge type so it was implemented.
[master < Epic] PR
[master < Task] PR
To keep docs changelog up to date, one more thing to do:
Enable changing edge (relationship) type through the CPP (mgp::Graph::ChangeType) and C (mgp::graph_edge_change_type) API