Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add renaming of edge types #1364

Merged
merged 16 commits into from
Oct 24, 2023
Merged

Add renaming of edge types #1364

merged 16 commits into from
Oct 24, 2023

Conversation

imilinovic
Copy link
Contributor

@imilinovic imilinovic commented Oct 13, 2023

There was a need to be able to change edge type so it was implemented.

[master < Epic] PR

  • Check, and update documentation if necessary
  • Write E2E tests
  • Compare the benchmarking results between the master branch and the Epic branch
  • Provide the full content or a guide for the final git message

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses
    Enable changing edge (relationship) type through the CPP (mgp::Graph::ChangeType) and C (mgp::graph_edge_change_type) API
  • Tag someone from docs team in the comments

@imilinovic imilinovic self-assigned this Oct 13, 2023
@imilinovic imilinovic added the feature feature label Oct 13, 2023
@gitbuda gitbuda changed the title [main < rename-label] Implement renaming relationship labels Implement renaming relationship labels Oct 16, 2023
@gitbuda gitbuda changed the title Implement renaming relationship labels Add renaming of edge types Oct 16, 2023
@gitbuda
Copy link
Member

gitbuda commented Oct 16, 2023

@antoniofilipovic & @imilinovic, if I recall correctly, by definition, edge types are immutable in the property graph -> take a look for incompatibilities and edge cases on that side (maybe some application code relies on that fact) 🤔

@imilinovic imilinovic marked this pull request as ready for review October 18, 2023 08:03
@imilinovic imilinovic added Ready for review PR is ready for review and removed draft labels Oct 18, 2023
@imilinovic imilinovic added this to the mg-v2.12.0 milestone Oct 18, 2023
@antoniofilipovic
Copy link
Collaborator

@gitbuda Basically this PR is used only for APOC functionality of renaming edge type: https://neo4j.com/labs/apoc/4.3/overview/apoc.refactor/apoc.refactor.rename.type/. Neo4j supports it so we wanted to add support on MAGE.

Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, but good work

src/query/procedure/mg_procedure_impl.cpp Outdated Show resolved Hide resolved
include/_mgp.hpp Show resolved Hide resolved
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments, but good work

Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@imilinovic imilinovic added the Docs needed Docs needed label Oct 23, 2023
@imilinovic
Copy link
Contributor Author

@vpavicic Will do docs today

@antoniofilipovic antoniofilipovic merged commit 1f118e7 into master Oct 24, 2023
6 checks passed
@antoniofilipovic antoniofilipovic deleted the cpp-api-rename-label branch October 24, 2023 15:12
as51340 pushed a commit that referenced this pull request Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs needed Docs needed feature feature Ready for review PR is ready for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants