Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add human readable memory allocations in show storage info #1366

Merged
merged 3 commits into from
Oct 16, 2023
Merged

Add human readable memory allocations in show storage info #1366

merged 3 commits into from
Oct 16, 2023

Conversation

as51340
Copy link
Contributor

@as51340 as51340 commented Oct 16, 2023

[master < Epic] PR

  • Check, and update documentation if necessary
  • Write E2E tests
  • Compare the benchmarking results between the master branch and the Epic branch
  • Provide the full content or a guide for the final git message

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses
  • Tag someone from docs team in the comments

@as51340 as51340 linked an issue Oct 16, 2023 that may be closed by this pull request
Add human readable memory allocations in SHOW STORAGE INFO #1352
Closed
@as51340 as51340 added the feature feature label Oct 16, 2023
@as51340 as51340 self-assigned this Oct 16, 2023
@as51340 as51340 added this to the mg-v2.12.0 milestone Oct 16, 2023
antoniofilipovic
antoniofilipovic approved these changes Oct 16, 2023
View reviewed changes
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to add this, nice!

@as51340 as51340 added the Docs needed Docs needed label Oct 16, 2023
@as51340 as51340 merged commit 7b0bafa into master Oct 16, 2023
6 checks passed
@as51340 as51340 deleted the human-readable-storage-info branch October 16, 2023 09:35
@vpavicic vpavicic mentioned this pull request Oct 16, 2023
Merged
10 tasks
as51340 added a commit that referenced this pull request Nov 10, 2023
@as51340
Add human readable memory allocations in show storage info (#1366)
10279c8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

@gitbuda gitbuda Awaiting requested review from gitbuda

Assignees

@as51340 as51340

Labels
Docs needed Docs needed feature feature
Projects
No open projects
memgraph-v2 issues
Status: ✅ Done
Milestone
mg-v2.12.0
Development

Successfully merging this pull request may close these issues.

Add human readable memory allocations in SHOW STORAGE INFO
2 participants
@as51340 @antoniofilipovic