Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw when exists() combined with CASE #1382

Merged
merged 6 commits into from Nov 2, 2023
Merged

Throw when exists() combined with CASE #1382

merged 6 commits into from Nov 2, 2023

Conversation

as51340
Copy link
Contributor

@as51340 as51340 commented Oct 19, 2023

Closes #1376
Out current architecture doesn't allow combining exists with anything except filtering because we would have to combine rule based planner with evaluation. Hence, current best solution is to explicitly throw (better than returning wrong results).

[master < Epic] PR

  • Check, and update documentation if necessary
  • Write E2E tests
  • Compare the benchmarking results between the master branch and the Epic branch
  • Provide the full content or a guide for the final git message

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses
  • Tag someone from docs team in the comments

@as51340 as51340 added the bug bug label Oct 19, 2023
@as51340 as51340 added this to the mg-v2.13.0 milestone Oct 19, 2023
@as51340 as51340 self-assigned this Oct 19, 2023
@as51340 as51340 marked this pull request as ready for review October 19, 2023 07:18
@as51340 as51340 merged commit 4aacd45 into master Nov 2, 2023
6 checks passed
@as51340 as51340 deleted the exists-case-when branch November 2, 2023 07:25
@as51340
Copy link
Contributor Author

as51340 commented Nov 2, 2023

Changelog: When using exists within CASE, utils::NotYetImplemented exception will be thrown.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bug Docs needed Docs needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Result return failed when using exists() in CASE WHEN
3 participants