Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support deleting paths #1383

Merged
merged 14 commits into from Nov 2, 2023
Merged

Support deleting paths #1383

merged 14 commits into from Nov 2, 2023

Conversation

as51340
Copy link
Contributor

@as51340 as51340 commented Oct 19, 2023

Closes #1365

[master < Epic] PR

  • Check, and update documentation if necessary
  • Write E2E tests
  • Compare the benchmarking results between the master branch and the Epic branch
  • Provide the full content or a guide for the final git message

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses
  • Tag someone from docs team in the comments

@as51340 as51340 added feature feature Docs - changelog only Docs - changelog only labels Oct 19, 2023
@as51340 as51340 added this to the mg-v2.13.0 milestone Oct 19, 2023
@as51340 as51340 self-assigned this Oct 19, 2023
@as51340 as51340 marked this pull request as ready for review October 30, 2023 06:33
andrejtonev
andrejtonev reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@andrejtonev andrejtonev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool addition, but I think the path code could be made faster.
Also missing tests.

src/query/plan/operator.cpp Outdated Show resolved Hide resolved
src/query/plan/operator.cpp Outdated Show resolved Hide resolved
src/query/plan/operator.cpp Outdated Show resolved Hide resolved
src/query/plan/operator.cpp Outdated Show resolved Hide resolved
andrejtonev
andrejtonev reviewed Oct 30, 2023
View reviewed changes
Copy link
Contributor

@andrejtonev andrejtonev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still missing the tests.

src/query/plan/operator.cpp Outdated Show resolved Hide resolved
@as51340 as51340 mentioned this pull request Nov 2, 2023
Merged
10 tasks
andrejtonev
andrejtonev approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@andrejtonev andrejtonev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@as51340
Copy link
Contributor Author

as51340 commented Nov 2, 2023

Changelog: The user can now detach delete path which is equivalent to deleting all nodes and relationships on that path.

@as51340 as51340 merged commit c942016 into master Nov 2, 2023
6 checks passed
@as51340 as51340 deleted the detach-delete-path branch November 2, 2023 13:07
@as51340 as51340 added Docs needed Docs needed and removed Docs - changelog only Docs - changelog only labels Nov 2, 2023
as51340 added a commit that referenced this pull request Nov 10, 2023
@as51340
Support deleting paths (#1383)
a09e0c1
@gitbuda gitbuda modified the milestones: mg-v2.13.0, mg-v2.12.1 Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrejtonev andrejtonev andrejtonev approved these changes

Assignees

@as51340 as51340

Labels
Docs needed Docs needed feature feature
Projects
No open projects
memgraph-v2 issues
Status: No status
Milestone
mg-v2.12.1
Development

Successfully merging this pull request may close these issues.

Add support for path deletion.
3 participants
@as51340 @andrejtonev @gitbuda