Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add counter for SetPropertiesCursor #1460

Merged
merged 6 commits into from Nov 7, 2023
Merged

Add counter for SetPropertiesCursor #1460

merged 6 commits into from Nov 7, 2023

Conversation

as51340
Copy link
Contributor

@as51340 as51340 commented Nov 6, 2023

[master < Epic] PR

  • Check, and update documentation if necessary
  • Write E2E tests
  • Compare the benchmarking results between the master branch and the Epic branch
  • Provide the full content or a guide for the final git message

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses
  • Tag someone from docs team in the comments

@as51340 as51340 changed the title Add failing unit test Add counters for SetProperties Nov 6, 2023
@as51340 as51340 changed the title Add counters for SetProperties Add counters for SetProperties Nov 6, 2023
@as51340 as51340 linked an issue Nov 6, 2023 that may be closed by this pull request
When updating all properties using map SetProperties operator is missing the counters #1430
Closed
@as51340 as51340 self-assigned this Nov 6, 2023
@as51340 as51340 added this to the mg-v2.13.0 milestone Nov 6, 2023
@as51340 as51340 added the bug bug label Nov 6, 2023
@as51340 as51340 marked this pull request as ready for review November 6, 2023 09:44
@as51340 as51340 changed the title Add counters for SetProperties Add counter for SetPropertiesCursor Nov 6, 2023
antoniofilipovic
antoniofilipovic approved these changes Nov 6, 2023
View reviewed changes
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💪

@as51340 as51340 merged commit f4b97fc into master Nov 7, 2023
6 checks passed
@as51340 as51340 deleted the set-properties-add-stts branch November 7, 2023 08:11
as51340 added a commit that referenced this pull request Nov 10, 2023
@as51340
Fix missing statistics for SetPropertiesCursor (#1460)
02258ac
@as51340 as51340 added the Docs - changelog only Docs - changelog only label Nov 13, 2023
@as51340
Copy link
Contributor Author

as51340 commented Nov 13, 2023

Bugfix: SetPropertiesCursor is now returning the number of updated properties as part of the metadata.

@gitbuda gitbuda modified the milestones: mg-v2.13.0, mg-v2.12.1 Nov 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

Assignees

@as51340 as51340

Labels
bug bug Docs - changelog only Docs - changelog only
Projects
None yet
Milestone
mg-v2.12.1
Development

Successfully merging this pull request may close these issues.

When updating all properties using map SetProperties operator is missing the counters
3 participants
@as51340 @antoniofilipovic @gitbuda