Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove filter profile info #1481

Merged
merged 14 commits into from Dec 3, 2023
Merged

Remove filter profile info #1481

merged 14 commits into from Dec 3, 2023

Conversation

Josipmrden
Copy link
Contributor

@Josipmrden Josipmrden commented Nov 9, 2023

Filter profile info was not updating during rewriting of queries.

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses
  • Tag someone from docs team in the comments

@vpavicic : Changelog message: Filter information message fixed in EXPLAIN and PROFILE queries to display what's exactly filtering in the filter expression.

@vpavicic I think I'll need to look about what currently our profile and explain information provides in the docs so we can update it

@Josipmrden Josipmrden marked this pull request as ready for review November 12, 2023 23:36
@Josipmrden Josipmrden added this to the mg-v2.13.0 milestone Nov 13, 2023
Copy link
Contributor

@as51340 as51340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the name of this PR is a bit misleading since you aren't actually remove filter profile info but rather changing the output of filter explain.

src/query/plan/rewrite/index_lookup.hpp Outdated Show resolved Hide resolved
src/query/plan/rewrite/join.hpp Outdated Show resolved Hide resolved
src/query/plan/rule_based_planner.hpp Outdated Show resolved Hide resolved
tests/e2e/filter_info/filter_info.py Show resolved Hide resolved
tests/e2e/index_hints/index_hints.py Show resolved Hide resolved
tests/e2e/analyze_graph/optimize_indexes.py Show resolved Hide resolved
@gitbuda gitbuda added Importance - I1 Importance - I1 Effort - Low Effort - Low Severity - S2 Severity - S2 labels Nov 16, 2023
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few comments

Copy link

sonarcloud bot commented Dec 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 40 Code Smells

No Coverage information No Coverage information
62.5% 62.5% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

src/query/plan/rewrite/index_lookup.hpp Outdated Show resolved Hide resolved
src/query/plan/rewrite/join.hpp Outdated Show resolved Hide resolved
@Josipmrden Josipmrden merged commit d58a464 into master Dec 3, 2023
6 checks passed
@Josipmrden Josipmrden deleted the remove-filter-profile-info branch December 3, 2023 20:23
@vpavicic vpavicic added Docs - changelog only Docs - changelog only and removed Docs needed Docs needed labels Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs - changelog only Docs - changelog only Effort - Low Effort - Low Importance - I1 Importance - I1 Severity - S2 Severity - S2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants