Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Organize coordinator group #1687

Merged
merged 16 commits into from Feb 8, 2024
Merged

Organize coordinator group #1687

merged 16 commits into from Feb 8, 2024

Conversation

as51340
Copy link
Contributor

@as51340 as51340 commented Feb 1, 2024

This PR creates RAFT cluster of coordinators which all know about each other. We remove --coordinator flag and add --raft-server-id and -raft-server-port flag in order to correctly initialize raft servers. Added ADD COORDINATOR query for connecting instances. Coordinators know about each other and can get info about the cluster state using SHOW INSTANCES. ATM CoordinatorLogStore, CoordinatorStateMachine and CoordinatorStateManager don't do anything too smart but they will in the future.

[master < Epic] PR

  • Check, and update documentation if necessary
  • Write E2E tests
  • Compare the benchmarking results between the master branch and the Epic branch
  • Provide the full content or a guide for the final git message

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses
  • Tag someone from docs team in the comments

@as51340 as51340 added the Docs needed Docs needed label Feb 1, 2024
@as51340 as51340 self-assigned this Feb 5, 2024
@as51340 as51340 marked this pull request as ready for review February 5, 2024 07:53
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, not much to comment 💪

@as51340 as51340 force-pushed the organize-coordinator-group branch 3 times, most recently from 6a04368 to e97944b Compare February 6, 2024 11:48
Copy link
Contributor

@andrejtonev andrejtonev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!
A few comments.
Didn't get into the raft stuff. I'll need a sync for that :D

src/coordination/coordinator_data.cpp Outdated Show resolved Hide resolved
src/coordination/coordinator_instance.cpp Show resolved Hide resolved
src/coordination/coordinator_instance.cpp Show resolved Hide resolved
src/coordination/coordinator_instance.cpp Show resolved Hide resolved
@as51340 as51340 enabled auto-merge (squash) February 8, 2024 08:32
@as51340 as51340 merged commit cf80687 into master Feb 8, 2024
8 checks passed
@as51340 as51340 deleted the organize-coordinator-group branch February 8, 2024 09:11
@as51340 as51340 added this to the mg-v2.15.0 milestone Feb 15, 2024
@as51340
Copy link
Contributor Author

as51340 commented Feb 22, 2024

@kgolubic release note: Added flags --raft-server-id and --raft-server-port for creating coordinators.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs needed Docs needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants