New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Organize coordinator group #1687
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good work, not much to comment 💪
6a04368
to
e97944b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
A few comments.
Didn't get into the raft stuff. I'll need a sync for that :D
50959d3
to
364e014
Compare
@kgolubic release note: Added flags |
This PR creates RAFT cluster of coordinators which all know about each other. We remove
--coordinator
flag and add--raft-server-id
and-raft-server-port
flag in order to correctly initialize raft servers. AddedADD COORDINATOR
query for connecting instances. Coordinators know about each other and can get info about the cluster state usingSHOW INSTANCES
. ATM CoordinatorLogStore, CoordinatorStateMachine and CoordinatorStateManager don't do anything too smart but they will in the future.[master < Epic] PR
[master < Task] PR
To keep docs changelog up to date, one more thing to do: