Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve registration queries #1809

Merged
merged 3 commits into from Mar 13, 2024
Merged

Improve registration queries #1809

merged 3 commits into from Mar 13, 2024

Conversation

as51340
Copy link
Contributor

@as51340 as51340 commented Mar 12, 2024

Change registration queries to support config map syntax.
Example:

"REGISTER INSTANCE instance_1 WITH CONFIG {'bolt_server': '127.0.0.1:7688', 'management_server': '127.0.0.1:10011', 'replication_server': '127.0.0.1:10001'};",
"ADD COORDINATOR 1 WITH CONFIG {'bolt_server': '127.0.0.1:7690', 'coordinator_server': '127.0.0.1:10111'}",

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here, including added/changed clauses
  • Tag someone from docs team in the comments

@as51340 as51340 added the Docs needed Docs needed label Mar 12, 2024
@as51340 as51340 self-assigned this Mar 12, 2024
@as51340 as51340 marked this pull request as ready for review March 13, 2024 07:50
@as51340 as51340 force-pushed the update-registration-queries branch from 6220f1a to bcb5c4a Compare March 13, 2024 07:50
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work, left one comment if you want to apply it

@as51340 as51340 enabled auto-merge (squash) March 13, 2024 11:35
@as51340 as51340 force-pushed the update-registration-queries branch from bcb5c4a to df4adfd Compare March 13, 2024 11:48
@as51340
Copy link
Contributor Author

as51340 commented Mar 13, 2024

@kgolubic release note: Updated queries used for registering replication instances and coordinator instances.

@as51340
Copy link
Contributor Author

as51340 commented Mar 13, 2024

docs will be added in batch together with few other PRs, before 10th April

@as51340 as51340 merged commit 24f8a14 into master Mar 13, 2024
6 checks passed
@as51340 as51340 deleted the update-registration-queries branch March 13, 2024 13:04
@as51340 as51340 added this to the mg-v2.16.0 milestone Apr 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs needed Docs needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants