-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pass toolchain's root into ExternalProject #1868
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathstuf
reviewed
Mar 27, 2024
Ignition
added
infrastructure
build system, packaging, libraries
Docs unnecessary
Docs unnecessary
labels
Mar 27, 2024
Ignition
force-pushed
the
correct_toolchain_use_for_libs
branch
from
March 27, 2024 12:24
231e2db
to
7b869f9
Compare
Ignition
changed the title
WIP: pass toolchain
Correctly pass toolchain's root into ExternalProject
Mar 27, 2024
Ignition
changed the title
Correctly pass toolchain's root into ExternalProject
Pass toolchain's root into ExternalProject
Mar 27, 2024
gitbuda
approved these changes
Mar 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
@mathstuf thanks a lot for your contribution!
@MarkoBarisic, yes, we should extend the activate
script by adding MG_TOOLCHAIN_ROOT
👀
mathstuf
reviewed
Mar 29, 2024
Ignition
force-pushed
the
correct_toolchain_use_for_libs
branch
from
April 2, 2024 14:23
4c2c730
to
7f90fee
Compare
Co-authored-by: Ben Boeckel <mathstuf@users.noreply.github.com>
Ignition
force-pushed
the
correct_toolchain_use_for_libs
branch
from
April 2, 2024 16:06
7f90fee
to
0b5daa7
Compare
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
With the new toolchain-v5 there was an issue where 3rd party lib was being built with incorrect libzstd on some developers machines. This causes linking issues.
Fix is to provide the toolchain's root via
CMAKE_PREFIX_PATH
in our usage ofExternalProject_Add
.Our toolchain environment file can be updated to introduce
MG_TOOLCHAIN_ROOT
to make this work.@MarkoBarisic @gitbuda should we republish toolchain-v5 to have
MG_TOOLCHAIN_ROOT
?[master < Task] PR
Documentation checklist