Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass toolchain's root into ExternalProject #1868

Merged
merged 2 commits into from
Apr 2, 2024

Conversation

Ignition
Copy link
Contributor

@Ignition Ignition commented Mar 27, 2024

Description

With the new toolchain-v5 there was an issue where 3rd party lib was being built with incorrect libzstd on some developers machines. This causes linking issues.

Fix is to provide the toolchain's root via CMAKE_PREFIX_PATH in our usage of ExternalProject_Add.

Our toolchain environment file can be updated to introduce MG_TOOLCHAIN_ROOT to make this work.

@MarkoBarisic @gitbuda should we republish toolchain-v5 to have MG_TOOLCHAIN_ROOT?

[master < Task] PR

  • Provide the full content or a guide for the final git message
    • "Pass toolchain's root into ExternalProject"

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • [Release note text]
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments

libs/CMakeLists.txt Outdated Show resolved Hide resolved
libs/CMakeLists.txt Outdated Show resolved Hide resolved
libs/CMakeLists.txt Outdated Show resolved Hide resolved
@Ignition Ignition self-assigned this Mar 27, 2024
@Ignition Ignition added infrastructure build system, packaging, libraries Docs unnecessary Docs unnecessary labels Mar 27, 2024
@Ignition Ignition added this to the mg-v2.16.0 milestone Mar 27, 2024
@Ignition Ignition added the bug bug label Mar 27, 2024
@Ignition Ignition force-pushed the correct_toolchain_use_for_libs branch from 231e2db to 7b869f9 Compare March 27, 2024 12:24
@Ignition Ignition marked this pull request as ready for review March 27, 2024 12:24
@Ignition Ignition changed the title WIP: pass toolchain Correctly pass toolchain's root into ExternalProject Mar 27, 2024
@Ignition Ignition enabled auto-merge (squash) March 27, 2024 12:40
@Ignition Ignition changed the title Correctly pass toolchain's root into ExternalProject Pass toolchain's root into ExternalProject Mar 27, 2024
Copy link
Member

@gitbuda gitbuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!
@mathstuf thanks a lot for your contribution!
@MarkoBarisic, yes, we should extend the activate script by adding MG_TOOLCHAIN_ROOT 👀

libs/CMakeLists.txt Outdated Show resolved Hide resolved
@Ignition Ignition force-pushed the correct_toolchain_use_for_libs branch from 4c2c730 to 7f90fee Compare April 2, 2024 14:23
Ignition and others added 2 commits April 2, 2024 17:06
Co-authored-by: Ben Boeckel <mathstuf@users.noreply.github.com>
@Ignition Ignition force-pushed the correct_toolchain_use_for_libs branch from 7f90fee to 0b5daa7 Compare April 2, 2024 16:06
Copy link

sonarcloud bot commented Apr 2, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@Ignition Ignition merged commit 1d7fdfd into master Apr 2, 2024
7 checks passed
@Ignition Ignition deleted the correct_toolchain_use_for_libs branch April 2, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bug Docs unnecessary Docs unnecessary infrastructure build system, packaging, libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants