Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add multiple pattern comprehensions handling in Return clause. #1874

Merged
merged 13 commits into from Apr 4, 2024
Merged

Add multiple pattern comprehensions handling in Return clause. #1874

merged 13 commits into from Apr 4, 2024

Conversation

Darych
Copy link
Contributor

@Darych Darych commented Mar 28, 2024 •
edited

Description

Add support for multiple pattern comprehensions inside Return clause.

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • [Release note text]
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments

@Darych Darych self-assigned this Mar 28, 2024
@Darych Darych added Docs needed Docs needed feature feature labels Mar 28, 2024
@Darych Darych added this to the mg-v2.16.0 milestone Mar 28, 2024
@Darych Darych marked this pull request as ready for review April 3, 2024 06:41
antoniofilipovic
antoniofilipovic approved these changes Apr 4, 2024
View reviewed changes
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One comment, everything else looks fine

src/query/plan/rule_based_planner.hpp Outdated Show resolved Hide resolved
@Darych Darych enabled auto-merge (squash) April 4, 2024 09:42
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 4, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Darych Darych merged commit 923fcd2 into master Apr 4, 2024
6 checks passed
@Darych Darych deleted the 1310-multiple-pattern-comprehensions branch April 4, 2024 11:02
@gitbuda gitbuda linked an issue Apr 5, 2024 that may be closed by this pull request
Implement Cypher pattern comprehension #1310
Closed
@kgolubic
Copy link
Contributor

kgolubic commented Apr 7, 2024

@Darych can you please provide me with Release notes and Docs PR?

@Darych Darych mentioned this pull request Apr 8, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Josipmrden Josipmrden Josipmrden left review comments

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

Assignees

@Darych Darych

Labels
Docs needed Docs needed feature feature
Projects
None yet
Milestone
mg-v2.16.0
Development

Successfully merging this pull request may close these issues.

Implement Cypher pattern comprehension
4 participants
@Darych @kgolubic @Josipmrden @antoniofilipovic