Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to register replica after main in HA #1911

Merged
merged 6 commits into from
Apr 8, 2024
Merged

Add option to register replica after main in HA #1911

merged 6 commits into from
Apr 8, 2024

Conversation

antoniofilipovic
Copy link
Collaborator

@antoniofilipovic antoniofilipovic commented Apr 5, 2024 •
edited

Description

This diff adds option to register replica after main has already been registered

[master < Task] PR

  • Provide the full content or a guide for the final git message
    • Add option to register replica after main in HA

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Add option to register replica after main in HA
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments

@antoniofilipovic antoniofilipovic added the feature feature label Apr 5, 2024
@antoniofilipovic antoniofilipovic self-assigned this Apr 5, 2024
@antoniofilipovic antoniofilipovic added this to the mg-v2.17.0 milestone Apr 5, 2024
@antoniofilipovic antoniofilipovic changed the title Add option to register replica after main Add option to register replica after main in HA Apr 5, 2024
@antoniofilipovic antoniofilipovic added the Docs needed Docs needed label Apr 6, 2024
@antoniofilipovic antoniofilipovic marked this pull request as ready for review April 7, 2024 10:57
as51340
as51340 requested changes Apr 8, 2024
View reviewed changes
Copy link
Contributor

@as51340 as51340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks goood!

src/coordination/coordinator_instance.cpp Outdated Show resolved Hide resolved
src/coordination/include/coordination/coordinator_handlers.hpp Outdated Show resolved Hide resolved
src/coordination/replication_instance_client.cpp Outdated Show resolved Hide resolved
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 8, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@antoniofilipovic
Copy link
Collaborator Author

tagging @kgolubic for 2.17

@antoniofilipovic antoniofilipovic added this pull request to the merge queue Apr 8, 2024
@antoniofilipovic antoniofilipovic removed this pull request from the merge queue due to a manual request Apr 8, 2024
@gitbuda gitbuda mentioned this pull request Apr 8, 2024
Open
5 tasks
@antoniofilipovic antoniofilipovic added this pull request to the merge queue Apr 8, 2024
Merged via the queue into master with commit 2434841 Apr 8, 2024
7 checks passed
@antoniofilipovic antoniofilipovic deleted the add-register-replica-after-main branch April 8, 2024 16:18
This was referenced May 10, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@as51340 as51340 as51340 approved these changes

Assignees

@antoniofilipovic antoniofilipovic

Labels
Docs needed Docs needed feature feature
Projects
None yet
Milestone
mg-v2.17.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antoniofilipovic @as51340