Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discard request leadership on follower #1932

Merged
merged 10 commits into from
Apr 12, 2024
Merged

Discard request leadership on follower #1932

merged 10 commits into from
Apr 12, 2024

Conversation

antoniofilipovic
Copy link
Collaborator

@antoniofilipovic antoniofilipovic commented Apr 12, 2024 •
edited

Description

This PR discards request leadership on follower

[master < Task] PR

  • Provide the full content or a guide for the final git message
    • Discard request leadership on follower

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Followers can no more accept user actions
  • Link the documentation PR here
    • Will be done prior to 2.17 release
  • Tag someone from docs team in the comments

@antoniofilipovic antoniofilipovic marked this pull request as ready for review April 12, 2024 12:31
@antoniofilipovic antoniofilipovic self-assigned this Apr 12, 2024
@antoniofilipovic antoniofilipovic added the Docs - changelog only Docs - changelog only label Apr 12, 2024
@antoniofilipovic antoniofilipovic added this to the mg-v2.17.0 milestone Apr 12, 2024
as51340
as51340 approved these changes Apr 12, 2024
View reviewed changes
Copy link
Contributor

@as51340 as51340 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Like it!

@antoniofilipovic
Copy link
Collaborator Author

@kgolubic tagging you here

@antoniofilipovic
Merge branch 'abandon-request-leadership-on-follower' of github.com:m…
99de595 
…emgraph/memgraph into abandon-request-leadership-on-follower
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 12, 2024

Quality Gate Passed Quality Gate passed

Issues
3 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
38.1% Duplication on New Code

See analysis details on SonarCloud

@antoniofilipovic antoniofilipovic added this pull request to the merge queue Apr 12, 2024
Merged via the queue into master with commit e68be30 Apr 12, 2024
7 checks passed
@antoniofilipovic antoniofilipovic deleted the abandon-request-leadership-on-follower branch April 12, 2024 17:32
@antoniofilipovic antoniofilipovic mentioned this pull request May 7, 2024
Merged
10 tasks
@kgolubic
Copy link
Contributor

@antoniofilipovic I've used this for RN:

Implemented changes to discard leadership requests on follower instances. This update ensures that followers no longer accept user actions intended for the leader

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@as51340 as51340 as51340 approved these changes

Assignees

@antoniofilipovic antoniofilipovic

Labels
bug bug Docs - changelog only Docs - changelog only feature feature
Projects
None yet
Milestone
mg-v2.17.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@antoniofilipovic @kgolubic @as51340