Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix same port bug on HA unit tests #1944

Merged
merged 2 commits into from
Apr 16, 2024
Merged

Fix same port bug on HA unit tests #1944

merged 2 commits into from
Apr 16, 2024

Conversation

antoniofilipovic
Copy link
Collaborator

@antoniofilipovic antoniofilipovic commented Apr 16, 2024 •
edited

Description

HA unit tests had the same port defined for the nuRaft server for coordinator_instance.cpp and coordinator_raft_state.cpp, which is 40112

[master < Task] PR

  • Provide the full content or a guide for the final git message
    • Fix same port bug

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • Internal, no docs
  • Link the documentation PR here
    • Internal, no docs
  • Tag someone from docs team in the comments

@antoniofilipovic antoniofilipovic self-assigned this Apr 16, 2024
@antoniofilipovic antoniofilipovic added this to the mg-v2.17.0 milestone Apr 16, 2024
@antoniofilipovic antoniofilipovic added bug bug Docs unnecessary Docs unnecessary labels Apr 16, 2024
@antoniofilipovic antoniofilipovic changed the title Fix same port bug Fix same port bug on HA unit tests Apr 16, 2024
MarkoBarisic
MarkoBarisic approved these changes Apr 16, 2024
View reviewed changes
Copy link
Contributor

@MarkoBarisic MarkoBarisic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@antoniofilipovic antoniofilipovic added this pull request to the merge queue Apr 16, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Apr 16, 2024
@MarkoBarisic MarkoBarisic added this pull request to the merge queue Apr 16, 2024
Merged via the queue into master with commit a1a6a44 Apr 16, 2024
10 checks passed
@MarkoBarisic MarkoBarisic deleted the fix-bug-ha-tests branch April 16, 2024 20:14
@antoniofilipovic antoniofilipovic mentioned this pull request May 7, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkoBarisic MarkoBarisic MarkoBarisic approved these changes

@as51340 as51340 Awaiting requested review from as51340

Assignees

@antoniofilipovic antoniofilipovic

Labels
bug bug Docs unnecessary Docs unnecessary tests
Projects
None yet
Milestone
mg-v2.17.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@antoniofilipovic @MarkoBarisic