Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix index lookup rewrite in case of pattern comprehension #1968

Merged
merged 1 commit into from
Apr 24, 2024

Conversation

Darych
Copy link
Contributor

@Darych Darych commented Apr 23, 2024

Description

Fix index lookup rewrite in case of pattern comprehension

CI Testing Labels

Please select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • [Release note text]
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments

@Darych Darych self-assigned this Apr 23, 2024
@Darych Darych added the Docs - changelog only Docs - changelog only label Apr 23, 2024
@Darych Darych added this to the mg-v2.16.1 milestone Apr 23, 2024
Copy link

sonarcloud bot commented Apr 23, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@Darych Darych linked an issue Apr 23, 2024 that may be closed by this pull request
@kgolubic
Copy link
Contributor

@Darych can you please provide me with the release note entry?

@Darych Darych added this pull request to the merge queue Apr 24, 2024
@Darych
Copy link
Contributor Author

Darych commented Apr 24, 2024

@Darych can you please provide me with the release note entry?

Fixed core dump when query used label or property-label index and pattern comprehension together.

Merged via the queue into master with commit 5bfe5f4 Apr 24, 2024
11 checks passed
@Darych Darych deleted the 1957-pattern-comprehension-label-index branch April 24, 2024 13:01
@kgolubic
Copy link
Contributor

@Darych I've rewritten the RN to be: This fix ensures robust index rewriting and prevents potential core dumps in situations involving pattern comprehension within queries. Previously, the application could fail when using label or property-label indices with pattern comprehensions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Docs - changelog only Docs - changelog only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memgraph fails on RollUpApply when indices are involved.
4 participants