-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replicate only durable commits to replicas during recovery #1991
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good to me
Maybe also comment about the PR name, we are sending only durable commits to replica in recovery, the buffer is not sent at all |
Quality Gate passedIssues Measures |
@kgolubic RN above, docs written |
Description
Send only durable part of the buffer to replicas during recovery
Better checker for jepsen test for easier debugging.
Improved logs to more easily reason about applying deltas during recovery.
Before this PR, even with
fsync
set to 1, replicas could get non-durable data from main. If main would die and get back, replica could be in more advanced state than main = issue.[master < Task] PR
Documentation checklist
RECOVERY
documentation#733