Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the libc function inline clang tidy check #1998

Merged
merged 2 commits into from
May 3, 2024

Conversation

antoniofilipovic
Copy link
Collaborator

@antoniofilipovic antoniofilipovic commented May 2, 2024

Description

This diff removes the libc specific check from clang tidy. llvmlibc-inline-function-decl causes some PRs to fail clang-tidy check. Since it is a check specific to libc (llvm), I would remove it, otherwise we will have issues when compiling with GCC.

[master < Task] PR

  • Provide the full content or a guide for the final git message
    • Remove the libc function inline clang tidy check

CI Testing Labels

Please select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label tag
  • Add the bug / feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • No need, internal
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from docs team in the comments

@antoniofilipovic antoniofilipovic self-assigned this May 2, 2024
@antoniofilipovic antoniofilipovic added this to the mg-v2.17.0 milestone May 2, 2024
@antoniofilipovic antoniofilipovic added the Docs unnecessary Docs unnecessary label May 2, 2024
@antoniofilipovic
Copy link
Collaborator Author

@kgolubic no need for release note here

Copy link

sonarcloud bot commented May 2, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@antoniofilipovic antoniofilipovic added this pull request to the merge queue May 3, 2024
Merged via the queue into master with commit e4e4dc9 May 3, 2024
11 checks passed
@antoniofilipovic antoniofilipovic deleted the remove-libc-inline-func-clang-tidy branch May 3, 2024 09:59
@as51340 as51340 restored the remove-libc-inline-func-clang-tidy branch May 9, 2024 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants