Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add dns resolution on endpoint parsing #2004

Merged
merged 18 commits into from
May 8, 2024
Merged

Add dns resolution on endpoint parsing #2004

merged 18 commits into from
May 8, 2024

Conversation

antoniofilipovic
Copy link
Collaborator

@antoniofilipovic antoniofilipovic commented May 3, 2024 •
edited

Description

This diff adds the option to do DNS resolution on registering replicas and/or coordinator instances.

Fixes: #1994

[master < Task] PR

  • Provide the full content or a guide for the final git message
    • Add DNS resolution on endpoint parsing

CI Testing Labels

Please select the appropriate CI test labels (CI -build=build-name -test=test-suite)

Documentation checklist

  • Add the documentation label tag
  • Add the bug/feature label tag
  • Add the milestone for which this feature is intended
    • If not known, set for a later milestone
  • Write a release note, including added/changed clauses
    • DNS resolution now works for endpoints
  • Link the documentation PR here
    • [Documentation PR link]
  • Tag someone from the docs team in the comments

@antoniofilipovic antoniofilipovic added Docs - changelog only Docs - changelog only CI -build=community -test=core Run community build and core tests on push CI -build=coverage -test=core Run coverage build and core tests on push CI -build=jepsen -test=core Run jepsen build and core tests on push CI -build=debug -test=core Run debug build and core tests on push CI -build=debug -test=integration Run debug build and integration tests on push CI -build=release -test=core Run release build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push CI -build=release -test=stress Run release build and stress tests on push CI -build=release -test=benchmark Run release build and benchmark on push labels May 3, 2024
@antoniofilipovic antoniofilipovic added this to the mg-v2.17.0 milestone May 3, 2024
@antoniofilipovic antoniofilipovic self-assigned this May 3, 2024
@antoniofilipovic antoniofilipovic marked this pull request as ready for review May 6, 2024 13:43
@antoniofilipovic antoniofilipovic added the feature feature label May 6, 2024
@antoniofilipovic
Copy link
Collaborator Author

@kgolubic tagging you here

@antoniofilipovic antoniofilipovic removed CI -build=debug -test=core Run debug build and core tests on push CI -build=debug -test=integration Run debug build and integration tests on push CI -build=release -test=core Run release build and core tests on push CI -build=release -test=e2e Run release build and e2e tests on push CI -build=release -test=stress Run release build and stress tests on push CI -build=release -test=benchmark Run release build and benchmark on push labels May 7, 2024
@antoniofilipovic antoniofilipovic added this pull request to the merge queue May 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 7, 2024
@antoniofilipovic antoniofilipovic added this pull request to the merge queue May 7, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 7, 2024
@antoniofilipovic antoniofilipovic added this pull request to the merge queue May 7, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 7, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
D Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 7, 2024
@antoniofilipovic antoniofilipovic added this pull request to the merge queue May 7, 2024
github-merge-queue bot pushed a commit that referenced this pull request May 7, 2024
@antoniofilipovic
Add dns resolution on endpoint parsing (#2004)
54726e5 
* dns resolution initial commit

* refactor endpoint to use dns resolution

* remove unused file, fix tests

* fix build

* add dns resolution test

* fix tests

* dns resolution initial commit

* refactor endpoint to use dns resolution

* remove unused file, fix tests

* fix build

* add dns resolution test

* fix tests

* move freeaddrinfo to onscopeexit

* fix clang tidy includes

* fix clang tidy includes, and spdlog error message
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 7, 2024
@antoniofilipovic antoniofilipovic added this pull request to the merge queue May 8, 2024
Merged via the queue into master with commit 6cd085e May 8, 2024
10 of 11 checks passed
@antoniofilipovic antoniofilipovic deleted the dns-resolution branch May 8, 2024 08:49
@MarkoBarisic MarkoBarisic modified the milestones: mg-v2.17.0, mg-v2.16.1 May 9, 2024
@kgolubic
Copy link
Contributor

@antoniofilipovic, can you please provide me with a Release note? What was done, and what can users do that they couldn't do before (since this is tagged as a feature)?

@kgolubic kgolubic added the bug bug label May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@as51340 as51340 as51340 approved these changes

@DavIvek DavIvek Awaiting requested review from DavIvek

Assignees

@antoniofilipovic antoniofilipovic

Labels
bug bug Docs - changelog only Docs - changelog only feature feature
Projects
None yet
Milestone
mg-v2.17.0
Development

Successfully merging this pull request may close these issues.

DNS resolution in Kubernetes not working properly
4 participants
@antoniofilipovic @kgolubic @as51340 @MarkoBarisic