-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enum datatype (v1) #2039
Merged
Enum datatype (v1) #2039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
579b735
to
49d3184
Compare
26044f4
to
0862b3c
Compare
Tracking
Documentation checklist
Extra work
|
b30e4a5
to
d8a08ab
Compare
Closed
15 tasks
f239227
to
2f7795a
Compare
8baf05f
to
e575f87
Compare
Add mocks for storage::Storage and storage::Storage::Accessor.
Fix manual test for expression pretty printer.
@Ignition I'm missing the Release note entry and documentation PR. Update: docs PR is memgraph/documentation#852 |
10 tasks
|
For Release note I'll use:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the Enum datatype.
Expected that if user has less than 256 named enums, each with less than 256 values, then their property store value representation will be 2 bytes for any enum value used. This will be better than string encoding, where "London" would be 7 bytes (1B size + 6 for the text).
Example commands