Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master < T1213] Match not allowed on replica #709

Merged
merged 8 commits into from
Dec 23, 2022

Conversation

brunos252
Copy link
Contributor

Closes #705
^ wrote my view on the problem in the issue. I believe the bug is in the updating of query rw_type which I amended here using my own logic and experience from that issue.

[master < Epic] PR

  • Check, and update documentation if necessary
  • Update changelog
  • Write E2E tests
  • Compare the benchmarking results between the master branch and the Epic branch
  • Provide the full content or a guide for the final git message

[master < Task] PR

  • Check, and update documentation if necessary
  • Update changelog
  • Provide the full content or a guide for the final git message

@brunos252 brunos252 added the bug bug label Dec 12, 2022
@brunos252 brunos252 self-assigned this Dec 12, 2022
@gitbuda
Copy link
Member

gitbuda commented Dec 12, 2022

Not bad! A test should have covered this, but obviously, it didn't 😂 -> perfect opportunity to improve -> how to test for this?

@gitbuda gitbuda merged commit 1f2a15e into master Dec 23, 2022
@gitbuda gitbuda deleted the T1213-MG-match-not-allowed-in-replica branch December 23, 2022 13:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] MATCH query not allowed on replicas
3 participants