Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master < T582-FL] Fix label-based auth using OLD view instead of NEW when merging nodes #755

Merged
merged 3 commits into from
Feb 1, 2023

Conversation

Josipmrden
Copy link
Contributor

@Josipmrden Josipmrden commented Jan 31, 2023

UNWIND 
[{id: '1', lat: 10, lng: 10}, {id: '2', lat: 10, lng: 10}, {id: '3', lat: 10, lng: 10}] AS row
MERGE (o:Location {id: row.id}) RETURN o;

did not work and threw an exception because newly created nodes were not seen and therefore prohibited.

Changelog message: Label based auth improved to see information about newly created nodes when merging nodes inside a query.

[master < Task] PR

  • Check, and update documentation if necessary
  • Update changelog
  • Provide the full content or a guide for the final git message

@Josipmrden Josipmrden changed the title FIX: Label based auth using storage::View::OLD instead of storage::View::NEW when merging nodes. FIX: Label based auth using storage::View::OLD instead of storage::View::NEW when merging nodes Jan 31, 2023
src/query/plan/operator.cpp Outdated Show resolved Hide resolved
@gitbuda gitbuda changed the title FIX: Label based auth using storage::View::OLD instead of storage::View::NEW when merging nodes Fix label-based auth using OLD view instead of NEW when merging nodes Feb 1, 2023
@antoniofilipovic antoniofilipovic changed the title Fix label-based auth using OLD view instead of NEW when merging nodes [master < T582-FL] Fix label-based auth using OLD view instead of NEW when merging nodes Feb 1, 2023
@antoniofilipovic antoniofilipovic merged commit 8f70c5f into master Feb 1, 2023
@antoniofilipovic antoniofilipovic deleted the T582-FL-label-based-auth-bug branch February 1, 2023 12:20
@gitbuda gitbuda added this to the v2.5.3 milestone Feb 6, 2023
@gitbuda gitbuda modified the milestones: v2.5.3, v2.6.0 Mar 3, 2023
@vpavicic
Copy link
Contributor

vpavicic commented Mar 6, 2023

RN: Newly created nodes now comply with the previously set label-based authorization rules.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants