Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master < T614] Add SHA256 password encryption #839

Merged
merged 14 commits into from
Apr 3, 2023

Conversation

Josipmrden
Copy link
Contributor

The task includes adding SHA as part of password authorization, which is less secure but a faster way of executing authentication. BCRYPT is still going to be our main authentication method for passwords but an additional flag will be present to run Memgraph with SHA algorithm.

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here
  • Tag someone from docs team in the comments

@Josipmrden Josipmrden added this to the mg-v2.7.0 milestone Mar 24, 2023
@Josipmrden Josipmrden self-assigned this Mar 24, 2023
@Josipmrden Josipmrden changed the title Add initial commit for PoC that SHA is indeed faster [master < T614] Add SHA password authentication Mar 24, 2023
@Josipmrden Josipmrden requested a review from gitbuda March 24, 2023 10:53
@Josipmrden Josipmrden marked this pull request as ready for review March 24, 2023 13:12
@Josipmrden Josipmrden added Ready for review PR is ready for review and removed Status - In Progress labels Mar 24, 2023
@Josipmrden Josipmrden changed the title [master < T614] Add SHA password authentication [master < T614] Add SHA256 password encryption Mar 24, 2023
src/auth/crypto.cpp Outdated Show resolved Hide resolved
@Josipmrden Josipmrden marked this pull request as draft March 24, 2023 13:52
tests/mgbench/client.cpp Outdated Show resolved Hide resolved
@Josipmrden Josipmrden marked this pull request as ready for review March 27, 2023 10:00
@antoniofilipovic antoniofilipovic removed the Ready for review PR is ready for review label Mar 28, 2023
@antoniofilipovic antoniofilipovic added the Needs change PR needs change label Mar 28, 2023
@antoniofilipovic
Copy link
Collaborator

@Josipmrden minor comments and suggestions. I think we should solve issue with depricated SHA256, it will complain all the time otherwise.

@Josipmrden Josipmrden added Ready for review PR is ready for review and removed Needs change PR needs change labels Mar 30, 2023
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug bug feature feature Ready for review PR is ready for review
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants