-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master < T614] Add SHA256 password encryption #839
Merged
antoniofilipovic
merged 14 commits into
master
from
T614-FL-add-sha-password-authentication
Apr 3, 2023
Merged
[master < T614] Add SHA256 password encryption #839
antoniofilipovic
merged 14 commits into
master
from
T614-FL-add-sha-password-authentication
Apr 3, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josipmrden
changed the title
Add initial commit for PoC that SHA is indeed faster
[master < T614] Add SHA password authentication
Mar 24, 2023
Josipmrden
added
Ready for review
PR is ready for review
and removed
Status - In Progress
labels
Mar 24, 2023
Josipmrden
changed the title
[master < T614] Add SHA password authentication
[master < T614] Add SHA256 password encryption
Mar 24, 2023
gitbuda
reviewed
Mar 24, 2023
antejavor
reviewed
Mar 24, 2023
@Josipmrden minor comments and suggestions. I think we should solve issue with depricated SHA256, it will complain all the time otherwise. |
Josipmrden
added
Ready for review
PR is ready for review
and removed
Needs change
PR needs change
labels
Mar 30, 2023
antoniofilipovic
approved these changes
Apr 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The task includes adding SHA as part of password authorization, which is less secure but a faster way of executing authentication. BCRYPT is still going to be our main authentication method for passwords but an additional flag will be present to run Memgraph with SHA algorithm.
[master < Task] PR
To keep docs changelog up to date, one more thing to do: