Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[master] < MG-include-storage-mode-inside-storage-mode-info-query #883

Merged
merged 14 commits into from
May 16, 2023
Merged

[master] < MG-include-storage-mode-inside-storage-mode-info-query #883

merged 14 commits into from
May 16, 2023

Conversation

gvolfing
Copy link
Contributor

@gvolfing gvolfing commented Apr 17, 2023 •
edited
Loading

[master < Task] PR

  • Check, and update documentation if necessary

docs PR

@gvolfing gvolfing self-assigned this Apr 17, 2023
@gvolfing gvolfing mentioned this pull request Apr 17, 2023
Closed
@gvolfing gvolfing marked this pull request as ready for review April 18, 2023 16:13
antaljanosbenjamin
antaljanosbenjamin reviewed Apr 19, 2023
View reviewed changes
Copy link
Contributor

@antaljanosbenjamin antaljanosbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What about isolation level? I know we talked about it, but I don't know if you supposed to add that also to the result of this query.

gvolfing and others added 4 commits April 19, 2023 13:19
@gvolfing @antaljanosbenjamin
Apply suggestions from code review
83a0dfa 
Co-authored-by: János Benjamin Antal <antaljanosbenjamin@users.noreply.github.com>
@gvolfing
Add functionality to obtain current global isolation level
7088567
@gvolfing
Merge branch 'MG-include-storage-mode-inside-storage-mode-info-query'…
7a1644a 
… of github.com:memgraph/memgraph into MG-include-storage-mode-inside-storage-mode-info-query
@gvolfing
Wheel of time
39676fc
This was referenced Apr 25, 2023
Merged
Merged
antaljanosbenjamin
antaljanosbenjamin suggested changes Apr 25, 2023
View reviewed changes
Copy link
Contributor

@antaljanosbenjamin antaljanosbenjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any tests. Could you please extend/create tests for the new functionality?

src/query/interpreter.cpp Outdated Show resolved Hide resolved
@gvolfing
Copy link
Contributor Author

I don't see any tests. Could you please extend/create tests for the new functionality?

Added e2e test for them.

@gvolfing gvolfing closed this Apr 26, 2023
@gvolfing gvolfing reopened this Apr 26, 2023
@gitbuda gitbuda added this to the mg-v2.8.0 milestone May 16, 2023
@gitbuda gitbuda added the feature feature label May 16, 2023
@antoniofilipovic antoniofilipovic merged commit c3e4f81 into master May 16, 2023
6 checks passed
@antoniofilipovic antoniofilipovic deleted the MG-include-storage-mode-inside-storage-mode-info-query branch May 16, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@antaljanosbenjamin antaljanosbenjamin antaljanosbenjamin approved these changes

@antoniofilipovic antoniofilipovic antoniofilipovic approved these changes

Assignees

@gvolfing gvolfing

Labels
feature feature
Projects
No open projects
memgraph-v2 issues
Status: ✅ Done
Milestone
mg-v2.8.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gvolfing @antaljanosbenjamin @antoniofilipovic @gitbuda