Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master < T891] (UN)LOCK query enhancement #933

Merged
merged 11 commits into from
May 16, 2023

Conversation

andrejtonev
Copy link
Contributor

@andrejtonev andrejtonev commented May 10, 2023

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here
  • Tag someone from docs team in the comments

docs PR #881
resolves #891

@andrejtonev andrejtonev marked this pull request as ready for review May 11, 2023 09:29
@andrejtonev
Copy link
Contributor Author

Pushed the new API.
I also updated the tests and replication client to handle the new API.

Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now! Great effort on first-ever PR on Memgraph 🥳 Check one more comment that is left, and if you think it is resolved, just ping me on Slack so I can 🚢 🇮🇹

@gitbuda gitbuda added the feature feature label May 16, 2023
@gitbuda gitbuda added this to the mg-v2.8.0 milestone May 16, 2023
@antoniofilipovic antoniofilipovic merged commit 802f8ac into master May 16, 2023
6 checks passed
@antoniofilipovic antoniofilipovic deleted the T891-MG-Add-lock-query-feedback branch May 16, 2023 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Implement return feedback on LOCK/UNLOCK DATA DIRECTORY query
4 participants