New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master < T938] Bolt v5 support #938
Conversation
…raph/memgraph into T921-MG-Bolt-v5-server-side-support
…Bolt-v5-server-side-support
…raph/memgraph into T921-MG-Bolt-v5-server-side-support
Missing notifications_minimum_severity and notifications_disabled_categories. |
Modified .clang-format to default to Google for all languages Modified yaml check to support multiple documents
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I left few comments. I want to test this on Monday and then that is it
The current version will fail during the driver tests due to the Java version on the CI server. Another test that does not fail, but is installing important missing packages on the fly is the GO v5 test. It needs a newer version of golang (>1.18.0), which it downloads and deploys locally. It's not ideal, but it's working so far. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested it and all works, approve from me
Changelog:
|
@andrejtonev But this is great info, so up until 5.2, not further? |
Yes. Actually we added support specifically for 5.2. 5.0 and 5.1 are not supported, those will default back to v4 |
[master < Task] PR
To keep docs changelog up to date, one more thing to do:
resolves #920
resolves #921