New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[master < T981] Reduce all shortest paths memory usage #981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@antoniofilipovic can we merge this to |
Josipmrden
changed the title
[master < T] Reduce all shortest paths memory usage
[master < T981] Reduce all shortest paths memory usage
Jul 28, 2023
please provide text for the PR message |
Josipmrden
reviewed
Jul 28, 2023
small comments, overall GJ |
Josipmrden
approved these changes
Jul 28, 2023
@vpavicic This PR changes the way memory is used in all shortest-path queries. From now on users should see lower memory usage with query performance almost staying the same. |
as51340
pushed a commit
that referenced
this pull request
Nov 10, 2023
* Change allocator to PoolResource
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TLDR: Based on the
mgbench
results, memory usage dropped from gigabytes to a few megabytes, while performance on all shortest paths dropped ~7% -> the decision is to merge because of the significant gain in memory usage while keeping performance high.[master < Task] PR
To keep docs changelog up to date, one more thing to do: