Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[master < T982] Add mgp any type to C++ query module wrapper #982

Merged
merged 2 commits into from Jun 20, 2023

Conversation

Josipmrden
Copy link
Contributor

@Josipmrden Josipmrden commented Jun 14, 2023

This is a C++ query module enhancement that allows users to write C++ query modules with arguments of variable type. So far only C API was able to do this, and the wrapper did not account for the Any type. This is an extension that allows for this misalignment.

[master < Task] PR

  • Check, and update documentation if necessary
  • Provide the full content or a guide for the final git message

To keep docs changelog up to date, one more thing to do:

  • Write a release note here
    You are now able to use mgp::Type::Any in C++ query modules to specify that the argument of the query modules can be of any type.

  • Tag someone from docs team in the comments

@Josipmrden Josipmrden added feature feature Ready for review PR is ready for review labels Jun 14, 2023
@Josipmrden Josipmrden added this to the mg-v2.9.0 milestone Jun 14, 2023
@Josipmrden Josipmrden self-assigned this Jun 14, 2023
@Josipmrden Josipmrden linked an issue Jun 14, 2023 that may be closed by this pull request
@Josipmrden
Copy link
Contributor Author

@vpavicic I'll begin docs update shortly

@Josipmrden Josipmrden changed the title [master < ] Add mgp any type to C++ query module wrapper [master < T982] Add mgp any type to C++ query module wrapper Jun 14, 2023
Copy link
Collaborator

@antoniofilipovic antoniofilipovic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@Josipmrden Josipmrden merged commit eb22edf into master Jun 20, 2023
6 checks passed
@Josipmrden Josipmrden deleted the mgp-add-any-type branch June 20, 2023 07:33
@vpavicic
Copy link
Contributor

ou can now use mgp::Type::Any while developing a custom query procedure
with the C++ API to specify that the argument of the procedure can be of any
type.

@Josipmrden oK?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature feature Ready for review PR is ready for review
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

[BUG] Add Any type in C++ query modules wrapper
3 participants