Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add project structure #2

Merged
merged 23 commits into from
Jul 17, 2020
Merged

Add project structure #2

merged 23 commits into from
Jul 17, 2020

Conversation

MarioHerceg
Copy link
Contributor

No description provided.

@MarioHerceg MarioHerceg reopened this Jul 15, 2020
gitbuda
gitbuda requested changes Jul 15, 2020
View reviewed changes
Copy link
Member

@gitbuda gitbuda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • I'm not sure why the build hasn't been started. On every push, there should be a build process under the Actions tab.
  • Is it a standard practice to have tests mixed with the implementation code. src/lib.rs contains implementation and unit tests.

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
tests/integration_test.rs Show resolved Hide resolved
tests/integration_test.rs Outdated Show resolved Hide resolved
tests/common/mod.rs Outdated Show resolved Hide resolved
gitbuda
gitbuda requested changes Jul 16, 2020
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
Cargo.toml Outdated Show resolved Hide resolved
@MarioHerceg MarioHerceg merged commit b313995 into master Jul 17, 2020
@MarioHerceg MarioHerceg deleted the T015-IN-add_project_structure branch July 17, 2020 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gitbuda gitbuda gitbuda approved these changes

@mihaeljaic mihaeljaic mihaeljaic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@MarioHerceg @gitbuda @mihaeljaic