Remove unnecessary panic for unreachable code #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes unnecessary panic for unreachable code
and unifies behavior for lazy and eager data fetching.
Although std::unreachable!() could be used here and
serve as self explanatory there is no reason for keeping
this behavior in a lib API that returns a Result type.
Test is rewritten since as far as I can see it was just a c/p where
no data was fetched in loop but code would panic on first
fetchone fn invocations since result was explicitly set to None.