Use iceberg-spark only for tests #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
racevedoo
force-pushed
the
use-iceberg-spark-only-for-tests
branch
2 times, most recently
from
1d898bb
to
80aa314
Compare
racevedoo
commented
Oct 15, 2022
| import org.apache.iceberg.*; | ||
| import org.apache.iceberg.data.InternalRecordWrapper; | ||
| import org.apache.iceberg.data.Record; | ||
| import org.apache.iceberg.io.BaseTaskWriter; | ||
| import org.apache.iceberg.io.FileAppenderFactory; | ||
| import org.apache.iceberg.io.FileIO; | ||
| import org.apache.iceberg.io.OutputFileFactory; | ||
| import org.apache.iceberg.relocated.com.google.common.collect.Sets; |
There was a problem hiding this comment.
needed to replace the usage of the shadowed version of guava with actual guava imports
racevedoo
force-pushed
the
use-iceberg-spark-only-for-tests
branch
from
80aa314
to
e159ba7
Compare
ismailsimsek
force-pushed
the
use-iceberg-spark-only-for-tests
branch
from
e159ba7
to
b6c1e3f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We do not need spark during runtime, so this moves iceberg-spark to the test scope, and adds iceberg dependencies (iceberg-core and iceberg-data)