Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docker: add Dockerfile #53

Merged
merged 1 commit into from
Nov 9, 2021
Merged

Conversation

racevedoo
Copy link
Collaborator

@racevedoo racevedoo commented Nov 9, 2021

This adds a Dockerfile based on java 11. It supports reading the config
file (application.properties) from a specific folder (/opt/conf),
making it easy to use in environments like Kubernetes, where it would be
a secret.

Closes #52

This adds a Dockerfile based on java 11. It supports reading the config
file (application.properties) from a specific folder (`/opt/conf`),
making it easy to use in environments like Kubernetes, where it would be
a secret
@racevedoo
Copy link
Collaborator Author

@ismailsimsek it would be great to add this to a public docker registry (maybe quay.io). Could you help me set this up?

@ismailsimsek
Copy link
Member

definitely, i can connect to Docker hub(i have account there) and then we can add to quay.io later on. what do you think about github container registry? i believe it will be part of the current repo and we can use github action to publish images.

https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry
found quick blog about it https://github.blog/2020-09-01-introducing-github-container-registry/

@racevedoo
Copy link
Collaborator Author

definitely, i can connect to Docker hub(i have account there) and then we can add to quay.io later on. what do you think about github container registry? i believe it will be part of the current repo and we can use github action to publish images.

https://docs.github.com/en/packages/working-with-a-github-packages-registry/working-with-the-container-registry found quick blog about it https://github.blog/2020-09-01-introducing-github-container-registry/

looks good too! any public registry works for me

@ismailsimsek
Copy link
Member

@racevedoo merging it to release on docker hub. then maybe we can add action to release on github-container-registry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker image
2 participants