-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Papercut fix: null bytes starting whitespace in sudoers files #751
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Number of dependencies and binary size impact report
Dependencies diff └─ sudo-rs [v0.2.0]
├─ glob [v0.3.1]
├─ libc [v0.2.147]
└─ log [v0.4.20] |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #751 +/- ##
==========================================
+ Coverage 54.86% 54.88% +0.02%
==========================================
Files 71 71
Lines 9731 9736 +5
==========================================
+ Hits 5339 5344 +5
Misses 4392 4392
☔ View full report in Codecov by Sentry. |
rnijveld
previously approved these changes
Sep 5, 2023
squell
force-pushed
the
fix-null-chars
branch
from
September 5, 2023 10:15
1535e12
to
aaf4b7d
Compare
rnijveld
approved these changes
Sep 5, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to no response for status checks
Sep 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is perhaps best reviewed commit by commit.
\
, no need for a sentinel)accept_if
, which was the only function for which you could rely on anErr
result to not have consumed input (whichaccept_escaped
then followed incorrectly) to prevent similar mistakes in the future.