Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use std::env::set_current_dir instead of libc::chdir #753

Merged
merged 1 commit into from
Sep 5, 2023
Merged

Conversation

japaric
Copy link
Collaborator

@japaric japaric commented Sep 5, 2023

as per the API docs, the implementation uses chdir on unix systems.

@github-actions
Copy link

github-actions bot commented Sep 5, 2023

Number of dependencies and binary size impact report

Metric main PR #753 Delta
Direct dependencies 3 3 -
Total dependencies 4 4 -
Binary size 1 MiB 1 MiB -
Text size 597.6 KiB 597 KiB -
Dependencies diff
 └─ sudo-rs [v0.2.0]
    ├─ glob [v0.3.1]
    ├─ libc [v0.2.147]
    └─ log [v0.4.20]

@codecov
Copy link

codecov bot commented Sep 5, 2023

Codecov Report

Patch coverage has no change and project coverage change: +0.03% 🎉

Comparison is base (0ac6fa8) 54.86% compared to head (1f2c635) 54.90%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #753      +/-   ##
==========================================
+ Coverage   54.86%   54.90%   +0.03%     
==========================================
  Files          71       71              
  Lines        9731     9724       -7     
==========================================
  Hits         5339     5339              
+ Misses       4392     4385       -7     
Files Changed Coverage Δ
src/exec/mod.rs 0.00% <0.00%> (ø)
src/system/mod.rs 82.23% <ø> (+0.43%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rnijveld rnijveld added the minor minor issue, PR without an issue label Sep 5, 2023
@rnijveld rnijveld added this pull request to the merge queue Sep 5, 2023
Merged via the queue into main with commit 9b9a7e4 Sep 5, 2023
16 checks passed
@squell squell deleted the ja-rm-chdir branch September 21, 2023 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
minor minor issue, PR without an issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants