refactor: use NonNull
to deal with pam_getenvlist
#758
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had trouble reading the original version and thought that the
curr_str
passed intoCStr::from_ptr
was not checked for null-ness but that was done inwhile
condition -- the not very visible dereferencing operator there through me off.The new version should hopefully make it clearer that a
NonNull
pointer is being passed intoCStr::from_ptr
. (Of course, it'd be even better ifCStr::from_ptr
signature wasfn(NonNull<u8>)
but we can't change the libstd API.) It also makes the dereferencing more explicit using theread
method.