-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
su CLI overhaul #792
su CLI overhaul #792
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #792 +/- ##
==========================================
+ Coverage 55.88% 57.44% +1.55%
==========================================
Files 74 74
Lines 9968 10523 +555
==========================================
+ Hits 5571 6045 +474
- Misses 4397 4478 +81
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I saw this IsAbsent
trait that was also on the sudo CLI overhaul. Could those two be shared? Maybe they are but I overlooked it.
that should be done in a follow up PR. I didn't base the su refactor on top of the sudo refactor branch so I couldn't reuse the trait. |
f18a471
to
bde50e8
Compare
this PR:
'-g ' ghost
as-g ghost
#791--
separatorsu -l -l
is rejectedsu --version root
is rejectedthis PR is best reviewed commit by commit