Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

su CLI overhaul #792

Merged
merged 12 commits into from
Nov 2, 2023
Merged

su CLI overhaul #792

merged 12 commits into from
Nov 2, 2023

Conversation

japaric
Copy link
Collaborator

@japaric japaric commented Oct 24, 2023

this PR:

this PR is best reviewed commit by commit

@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (870d15b) 55.88% compared to head (bde50e8) 57.44%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #792      +/-   ##
==========================================
+ Coverage   55.88%   57.44%   +1.55%     
==========================================
  Files          74       74              
  Lines        9968    10523     +555     
==========================================
+ Hits         5571     6045     +474     
- Misses       4397     4478      +81     
Files Coverage Δ
src/su/context.rs 61.11% <100.00%> (+0.65%) ⬆️
src/su/mod.rs 0.00% <0.00%> (ø)
src/su/cli.rs 94.63% <92.76%> (+1.89%) ⬆️

... and 17 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@pvdrz pvdrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saw this IsAbsent trait that was also on the sudo CLI overhaul. Could those two be shared? Maybe they are but I overlooked it.

@japaric
Copy link
Collaborator Author

japaric commented Nov 2, 2023

I saw this IsAbsent trait that was also on the sudo CLI overhaul. Could those two be shared? Maybe they are but I overlooked it.

that should be done in a follow up PR. I didn't base the su refactor on top of the sudo refactor branch so I couldn't reuse the trait.

@japaric japaric added this pull request to the merge queue Nov 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Nov 2, 2023
@pvdrz pvdrz added this pull request to the merge queue Nov 2, 2023
Merged via the queue into main with commit d5c66f0 Nov 2, 2023
15 checks passed
@japaric japaric deleted the refactor-su-cli branch November 3, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants