Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changing from Arabic to English isn't possible #275

Closed
EZ0010 opened this issue Dec 22, 2020 · 2 comments
Closed

changing from Arabic to English isn't possible #275

EZ0010 opened this issue Dec 22, 2020 · 2 comments
Assignees
Milestone

Comments

@EZ0010
Copy link

EZ0010 commented Dec 22, 2020

Description

there is some kind of bug when changing language of mempool from Arabic language to English, it doesn't work probably. it works on other languages but not Arabic I don't know why.

Version

current version on mempool.space (maybe c7abb7a0)

Steps to reproduce

  1. visit mempool from a browser that sends accept-language: ar in the headers.
  2. it will show Arabic as default language, change language to English, it won't do anything, it will refresh the page.
  3. type mempool.space/en in the URL, it will change the language.
  4. refresh the page after the language changed it will go back to Arabic ( it doesn't save preferences).

Expected behaviour

change language and save preferences

Actual behaviour

doesn't change language and save preferences

@wiz
Copy link
Member

wiz commented Dec 23, 2020

Yeah we're about to deploy a new server side rendering system which will change the way i18n works entirely, but for now you can clear your cache and it should work

@wiz wiz self-assigned this Dec 23, 2020
@EZ0010 EZ0010 closed this as completed Dec 23, 2020
@wiz wiz reopened this Jan 12, 2021
@wiz
Copy link
Member

wiz commented Jan 12, 2021

Re-opening due to possibly reproducing again

@wiz wiz closed this as completed in 627e8e5 Jan 12, 2021
@softsimon softsimon added this to the v2.1 milestone Feb 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants