Check for shard key or sort key before creating the temporary command #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This PR addresses a compatibility issue in Singlestore for incremental models using
shard_key
orsort_key
. Previously, attempting to use these keys would fail due to an incorrect assumption that temporary tables are rowstore, which is not supported by Singlestore forCLUSTERED COLUMNAR
indexes.Details:
shard_key
orsort_key
couldn't be deployed as incremental tables because the system tried to create them as rowstore temporary tables, conflicting with Singlestore's requirements.shard_key
orsort_key
, it's created as a "temporary" table (compatible with these keys), otherwise, it defaults to "rowstore temporary".