onLogin playerSession.getPlayer() is null

[nikolaykuz]

public class ConnectGameRoom extends GameRoomSession {

    @Override
public void onLogin(PlayerSession playerSession)
{
    System.out.println(playerSession.getPlayer() == null);
    }

}

prints true. Why is it so?

[nikolaykuz]

seems that in LoginHandler handleGameRoomJoin parameter player is not used at all.

[menacher]

This is known, meaning I have a TODO in code for this.
public static PlayerSession newPlayerSession(GameRoom gameRoom)
{
// TODO the player has to be set here after doing lookup.
return new PlayerSessionBuilder().parentGameRoom(gameRoom).build();
}
org.menacheri.jetserver.app.impl.Sessions class is used to create player sessions. This code is invoked by the GameRoomSession.getSessionInstance() method. You can override to lookup the player object when necessary.

[menacher]

If you have alternate suggestions on this, let me know. The reason "Player" object has lower precedence is that it will be hooked up from backend database based on the ref key, when someone uses jetserver. For the trivial example games I have done, it is un-necessary.

[nikolaykuz]

That's a little confusing, in order to that I have to modify the internal code and build the project again to get new jar files.

public static PlayerSession newPlayerSession(GameRoom gameRoom)
should be changed to
public static PlayerSession newPlayerSession(GameRoom gameRoom, Player player)
and also calls to this function I guess. For now I just want to have initalized Player inside PlayerSession to be able to print userName.

[menacher]

Hmm, yes its little confusing. I will modify the signature of newPlayerSession to what you have mentioned. I don't think you would need to touch internal code.
You just need to override this method of the abstract class - GameRoomSession
@OverRide
public PlayerSession createPlayerSession()
{
PlayerSession playerSession = getSessionInstance();
return playerSession;
}
And inject your Player instance here. No need to use the static factory at all. But let me try to re-factor this part as you have said.

Given an option, at which point would you have the player looked up from database during the login process? Any suggestions.

[nikolaykuz]

Okay, please let me know when I can download a new version of the code and jars.

[nikolaykuz]

For now I am using a hack to distinguish different clients

public class ConnectGameRoom extends GameRoomSession {
@OverRide
public PlayerSession getSessionInstance()
{
String name = "PLAYER" + playerId;
String email = name + "@gmail.com";

    Player player = new DefaultPlayer(playerId, name, email);
    PlayerSession playerSession = new PlayerSessionBuilder().parentGameRoom(this).player(player).build();

    playerId++;

    return playerSession;
}

}

[menacher]

This works, but like you said not the best solution. Let me see if I can clean it up.