[Feat] issue #1 exclude tags (html clean-up) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliviermills
changed the title
nickscamara
reviewed
Apr 19, 2024
nickscamara
reviewed
Apr 19, 2024
|
CI/CD is failing because we hit the llamaparse rate limit |
|
@rafaelsideguide Now that we have an initial testing framework, we should start testing these changes and get this merged. also @oliviermills quick thing, I noticed that this pr was made before we switched to AGPL 3.0, can you just confirm that you agree to relicense your contributions under the new license? Once that's done, we can proceed to merging them! (you can just write a comment here saying "I agree to relicense my contributions to the AGPL" - see #134 for more context) Thank you. |
nickscamara
added
in review
waiting-for-license
and removed
wip
waiting-for-i-tests
labels
|
I agree to relicense my contributions to the AGPL 🤗 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the exclude tag list with a function that does nicer and safer clean up. Resolves #1
Added basics tests for the function.
Important: should add an integration test with a much larger variety of html pages see #15