Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ed25519 support #288

Closed
wants to merge 1 commit into from
Closed

ed25519 support #288

wants to merge 1 commit into from

Conversation

M1cha
Copy link

@M1cha M1cha commented Jun 28, 2019

This adds support for auth-requests signed with ed25519 keys.
This is currently lacking changes to the tests for testing ed25519 in addition to rsa.

This adds support for auth-requests signed with ed25519 keys.

Changelog: None
Signed-off-by: Michael Zimmermann <michael.zimmermann@grandcentrix.net>
@M1cha M1cha marked this pull request as ready for review June 28, 2019 09:34
@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #288 into master will increase coverage by 39.72%.
The diff coverage is 50%.

@@             Coverage Diff             @@
##           master     #288       +/-   ##
===========================================
+ Coverage   38.63%   78.35%   +39.72%     
===========================================
  Files          40       40               
  Lines        2643     2647        +4     
===========================================
+ Hits         1021     2074     +1053     
+ Misses       1458      405     -1053     
- Partials      164      168        +4
Impacted Files Coverage Δ
model/authset.go 0% <ø> (ø) ⬆️
model/device.go 100% <ø> (ø) ⬆️
model/devadm-authset-req.go 0% <0%> (ø) ⬆️
devauth/devauth.go 86.96% <0%> (+40.07%) ⬆️
model/preauthreq.go 0% <0%> (ø) ⬆️
store/mongo/migration_1_3_0.go 78.26% <100%> (+78.26%) ⬆️
model/authreq.go 38.88% <100%> (+0.79%) ⬆️
api/http/model_pre_auth_req.go 82.35% <100%> (+82.35%) ⬆️
utils/crypto.go 48.27% <45.09%> (-5.58%) ⬇️
server.go 84% <0%> (+4%) ⬆️
... and 22 more

@alfrunes
Copy link
Contributor

alfrunes commented Aug 6, 2020

Superseded by #369

@alfrunes alfrunes closed this Aug 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants