New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MEN-3978: Rename environment tools to grub-mender-grubenv-*. #16
Conversation
05b4073
to
728c7c7
Compare
This requires followups in the client and in meta-mender, but it's a start. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The test is not running, it silently fails in the make
command:
++ sed -ne '/^mender_rootfsa_part=/ {s/^mender_rootfsa_part=//; p}' mender_grubenv_defines
sed: can't read mender_grubenv_defines: No such file or directory
I also run into the same error locally when trying to understand better the test.
By the way, nice idea adding this test! 🎸 |
Well spotted! I think this is not important to the test, but it should be fixed anyway. I'll definitely take a look at it. |
This renames the tools, adjusts the install scripts, and adds a test for the Makefile installation. There is also a new target, "install-legacy-tools", which installs the tools using the old names. Changelog: User space tools, "fw_printenv" and "fw_setenv" have been renamed to "grub-mender-grubenv-print" and "grub-mender-grubenv-set", respectively. This has been done in order to avoid conflict with U-Boot's user space tools, which have the same names. Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
It only took seven months, but at last I have fixed this! :-) |
Changelog: none Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
This renames the tools, adjusts the install scripts, and adds a test
for the Makefile installation. There is also a new target,
"install-legacy-tools", which installs the tools using the old names.
Changelog: User space tools, "fw_printenv" and "fw_setenv" have been
renamed to "grub-mender-grubenv-print" and "grub-mender-grubenv-set",
respectively. This has been done in order to avoid conflict with
U-Boot's user space tools, which have the same names.
Signed-off-by: Kristian Amlie kristian.amlie@northern.tech