Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MEN-3978: Rename environment tools to grub-mender-grubenv-*. #16

Merged
merged 2 commits into from Aug 25, 2021

Conversation

kacf
Copy link
Member

@kacf kacf commented Oct 30, 2020

This renames the tools, adjusts the install scripts, and adds a test
for the Makefile installation. There is also a new target,
"install-legacy-tools", which installs the tools using the old names.

Changelog: User space tools, "fw_printenv" and "fw_setenv" have been
renamed to "grub-mender-grubenv-print" and "grub-mender-grubenv-set",
respectively. This has been done in order to avoid conflict with
U-Boot's user space tools, which have the same names.

Signed-off-by: Kristian Amlie kristian.amlie@northern.tech

@kacf kacf force-pushed the rename branch 3 times, most recently from 05b4073 to 728c7c7 Compare October 30, 2020 10:38
@kacf
Copy link
Member Author

kacf commented Oct 30, 2020

This requires followups in the client and in meta-mender, but it's a start.

Copy link
Contributor

@lluiscampos lluiscampos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is not running, it silently fails in the make command:

++ sed -ne '/^mender_rootfsa_part=/ {s/^mender_rootfsa_part=//; p}' mender_grubenv_defines
sed: can't read mender_grubenv_defines: No such file or directory

I also run into the same error locally when trying to understand better the test.

tests/test_makefile.sh Show resolved Hide resolved
@lluiscampos
Copy link
Contributor

The test is not running (...)

By the way, nice idea adding this test! 🎸

@kacf
Copy link
Member Author

kacf commented Nov 2, 2020

The test is not running, it silently fails in the make command:

Well spotted! I think this is not important to the test, but it should be fixed anyway. I'll definitely take a look at it.

This renames the tools, adjusts the install scripts, and adds a test
for the Makefile installation. There is also a new target,
"install-legacy-tools", which installs the tools using the old names.

Changelog: User space tools, "fw_printenv" and "fw_setenv" have been
renamed to "grub-mender-grubenv-print" and "grub-mender-grubenv-set",
respectively. This has been done in order to avoid conflict with
U-Boot's user space tools, which have the same names.

Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
@kacf
Copy link
Member Author

kacf commented Jun 7, 2021

The test is not running, it silently fails in the make command:

Well spotted! I think this is not important to the test, but it should be fixed anyway. I'll definitely take a look at it.

It only took seven months, but at last I have fixed this! :-)

Changelog: none

Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
@kacf kacf merged commit 1a7db96 into mendersoftware:master Aug 25, 2021
@kacf kacf deleted the rename branch August 25, 2021 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants