chore: Logging improvement #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently we log all events when the healthcheck logs are mostly useful during configuring/debugging but not during normal operations. Bigger amount of logs makes it longer to find an event and increases logs saving costs. Changelog: Title Ticket: None Signed-off-by: Alex Miliukov <oleksandr.miliukov@northern.tech>
|
Merging these commits will result in the following changelog entries: Changelogsintegration-test-runner (master)New changes in integration-test-runner since master:
|
oleorhagen
reviewed
Feb 2, 2023
main.go
Outdated
|
|
||
| r := gin.New() | ||
| r.Use( | ||
| gin.LoggerWithWriter(gin.DefaultWriter, "/_health"), |
There was a problem hiding this comment.
Hmm, I'm not completely following, so if I'm running at the info level, then what will this show? Will it still ignore _health?
There was a problem hiding this comment.
Yes, the idea is to ignore logging for _health endpoint for log levels above debug and only have them for debug and trace.
There was a problem hiding this comment.
Understood, thx 👍 I was a bit lazy, but I see now that _health is the explicit filter to the logger.
Small suggestion, create a string locally, with filter := "_health" and pass it into the gin.LoggerWithWriter?
| @@ -207,16 +207,22 @@ func processGitHubWebhook( | |||
| if conf.isProcessPREvents { | |||
| pr := webhookEvent.(*github.PullRequestEvent) | |||
| return processGitHubPullRequest(ctx, pr, githubClient, conf) | |||
| } else { | |||
oleorhagen
approved these changes
Feb 2, 2023
Changelog: None Ticket: None Signed-off-by: Alex Miliukov <oleksandr.miliukov@northern.tech>
oleorhagen
approved these changes
Feb 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intention of the change is to improve logging to reduce amount of log entries, which will contribute to infra costs savings and making work with logs more comfortable.
The idea is to use
/_healthendpoint for the healthchecks by a load balancer and don't log those calls.