feat: Also comment on cherry-picking to the latest released version #214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Won't pass CI in some of the old tests due to the changes, which brings up the question of the integration version used in unit tests... I know we've been over this before, but hardcoding it could be an option for our tests to get a known version.. But then again, has some weaknesses too. What are your thoughts on the topic these days @lluiscampos ? |
oleorhagen
force-pushed
the
QA-496
branch
2 times, most recently
from
c186905
to
079b9ab
Compare
|
I know the inline testdata is gigantic. You want it split out in a separate file? |
We don't always know if the latest version will need support in the future or not, so we really have to cherry-pick to it, just in case. Ticket: QA-496 Changelog: None Signed-off-by: Ole Petter <ole.orhagen@northern.tech>
|
@lluiscampos more to your liking? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't always know if the latest version will need support in the future or
not, so we really have to cherry-pick to it, just in case.
Ticket: QA-496
Changelog: None
Signed-off-by: Ole Petter ole.orhagen@northern.tech