Fix writing of corrupt Artifact: type-info is missing type for rootfs… #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 😸 I created a pipeline for you here: Pipeline-260289028 Build Configuration Matrix
|
…-image. Changelog: Fix regression which caused the "write rootfs-image" command to produce a corrupt Artifact. The same versions that write such an Artifact will also accept it, but both issues have been fixed: A corrupt Artifact is not written anymore, nor will corrupt Artifacts be accepted. If you have produced an Artifact using a version of mender-artifact prior to 3.5.1, you may have to recreate it. Signed-off-by: Kristian Amlie <kristian.amlie@northern.tech>
kacf
force-pushed
the
corrupt_type-info
branch
from
dfee237
to
fb0ff47
Compare
|
Hello 😸 I created a pipeline for you here: Pipeline-260294102 Build Configuration Matrix
|
lluiscampos
approved these changes
Feb 23, 2021
There was a problem hiding this comment.
Sneaky bug. The fix looks good to me, but last word is on @oleorhagen
|
And very good |
oleorhagen
approved these changes
Feb 23, 2021
| if img.typeInfoV3 == nil || img.typeInfoV3.Type != img.updateType { | ||
| return errors.New("Type in type-info header does not match header-info: " + | ||
| "Corrupt Artifact. " + | ||
| "This was a known bug in some versions of mender-artifact prior to 3.5.1. " + |
There was a problem hiding this comment.
Suggestion: How about: is a known bug?
There was a problem hiding this comment.
Good point, I will change that.
| @@ -184,6 +191,10 @@ func MakeAnyImageArtifact(version int, signed bool, | |||
| ArtifactName: []string{"mender-1.0"}, | |||
| CompatibleDevices: []string{"vexpress"}, | |||
| }, | |||
| TypeInfoV3: &artifact.TypeInfoV3{ | |||
|
@kacf did you forget about this one? 😸 |
|
No, but I want to take a bit more time to think about this. As we discussed, maybe it's better to remove the field altogether. I'll return to it once I have fewer things on my plate! :-) |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…-image.
Changelog: Fix regression which caused the "write rootfs-image"
command to produce a corrupt Artifact. The same versions that write
such an Artifact will also accept it, but both issues have been fixed:
A corrupt Artifact is not written anymore, nor will corrupt Artifacts
be accepted. If you have produced an Artifact using a version of
mender-artifact prior to 3.5.1, you may have to recreate it.
Signed-off-by: Kristian Amlie kristian.amlie@northern.tech