1.0.x: MEN-5290: Several robustness fixes around re-connection #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lluiscampos, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline". my commands and optionsYou can trigger a pipeline on multiple prs with:
You can cherry pick to a given branch or branches with:
|
lluiscampos
force-pushed
the
1.0.x-MEN-5290-fix-reconnect
branch
from
8bd916e
to
de1d2d4
Compare
* Trigger re-connection when either token or server URL obtained from D-Bus signal has changed. Previously, it was enough with having a token with "some length" for the code to believe the device was authenticated and not trigger a re-connect. * Abort connecting after 10 retries. Previously it would reconnect forever with the same server URL, which will result in a deadlock if the url (or the token) changed while re-connecting. Changelog: Commit Signed-off-by: Lluis Campos <lluis.campos@northern.tech> (cherry picked from commit e382937) Signed-off-by: Lluis Campos <lluis.campos@northern.tech>
lluiscampos
force-pushed
the
1.0.x-MEN-5290-fix-reconnect
branch
from
de1d2d4
to
019c396
Compare
|
@mender-test-bot start pipeline 🪘 |
|
Hello 😸 I created a pipeline for you here: Pipeline-440080096 Build Configuration Matrix
|
|
@mender-test-bot start pipeline --pr meta-mender/1552 |
|
Build for Mender 2.6.x @ Pipeline 440088069 |
Note that only tidying has been done, no changes in vendor folder. Changelog: None Signed-off-by: Lluis Campos <lluis.campos@northern.tech>
|
@mzedel Can you look at the second commit? |
Changelog: None Signed-off-by: Lluis Campos <lluis.campos@northern.tech>
mzedel
approved these changes
Jan 3, 2022
There was a problem hiding this comment.
Based on the changes to the mod files this looks fine, but the check does a way better job than me looking at the hashes...
One other thing though:
Copyright 2022 Northern.tech' not found in LICENSE. Wrong year maybe?
I guess we run into these more frequently this time of a year 😉
|
@mzedel Funny enough, the cherry pick is "from last year" so it passed the check... but the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #51.